fix(dashmate): dapi kills host machine on container stop #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To scale (run multiple instances) DAPI we currently using PM2 (process manager based on Node.JS custer) inside Docker container. It starts multiple processes inside one container.
This approach has multiple downsides:
What was done?
platform.dapi.api.docker.deploy.replicas
option to configure the number of DAPI instances (1 by default).env
that invalidates docker build cacheFixed already-known flaky issues to make CI green:
--wait-for-readiness
not waiting for DAPI availabilityHow Has This Been Tested?
With local network
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only