feat(platform)!: ability to transfer documents #1826
Merged
+5,242
−959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
changed the title
QuantumExplorer
changed the title
pauldelucia
previously approved these changes
Apr 22, 2024
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs
Outdated
Show resolved
Hide resolved
packages/rs-dpp/src/data_contract/document_type/v0/random_document.rs
Outdated
Show resolved
Hide resolved
...ns/documents_batch/action_validation/document_transfer_transition_action/structure_v0/mod.rs
Outdated
Show resolved
Hide resolved
pauldelucia
reviewed
Apr 22, 2024
...ions/documents_batch/action_validation/document_delete_transition_action/structure_v0/mod.rs
Outdated
Show resolved
Hide resolved
pauldelucia
reviewed
Apr 22, 2024
...ons/documents_batch/action_validation/document_replace_transition_action/structure_v0/mod.rs
Outdated
Show resolved
Hide resolved
…try_from_schema/v0/mod.rs Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…ment.rs Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_transfer_transition_action/structure_v0/mod.rs Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_delete_transition_action/structure_v0/mod.rs Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
…on/state_transitions/documents_batch/action_validation/document_replace_transition_action/structure_v0/mod.rs Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com>
pauldelucia
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented / What was done?
The ability to transfer documents between identities was a sorely missed feature, in this PR we implement a document transfer action. We also introduce the $transferredAt, $transferredAtBlockHeight and $transferredAtCoreBlockHeight.
Mutable documents can not be transferred, and transferable documents must not be mutable.
How Has This Been Tested?
A lot of Tests were added.
Breaking Changes
Their are multiple breaking changes, including having to change the serialization of documents to incorporate 9 time fields ($createdAt, $createdAtBlockHeight, $createdAtCoreBlockHeight, $updatedAt...).
Checklist:
For repository code-owners and collaborators only