refactor(sdk)!: don't return Arc in SdkBuilder #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fominok
reviewed
May 7, 2024
packages/rs-sdk/src/sdk.rs
Outdated
| PlatformVersion::set_current(self.version); | ||
|
|
||
| let sdk= match self.addresses { | ||
| let sdk= match self.addresses { |
fominok
previously approved these changes
May 7, 2024
QuantumExplorer
approved these changes
May 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Based on team's feedback, it's not a good idea to return Arc from SdkBuilder::build().
What was done?
Refactored the code to:
CloneonSdkand make Sdk internally thread-safeAccompanying PR: dashpay/rs-platform-explorer#48
How Has This Been Tested?
GHA
Breaking Changes
SdkBuilder::build() now returns Sdk instead of Arc.
Checklist:
For repository code-owners and collaborators only