Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename validate to full_validation #1845

Merged
merged 1 commit into from
May 13, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 13, 2024

Issue being fixed or feature implemented

For Data Contract validation we use confusing validate flag. It actually doesn't disable/enable validation but enable additional validation rules.

What was done?

  • Renamed the validate flag to full_validation.

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone May 13, 2024
@shumkov shumkov changed the title refactor: rename validate to full_validation refactor: rename validate to full_validation May 13, 2024
@QuantumExplorer QuantumExplorer merged commit 7e5b932 into v1.0-dev May 13, 2024
65 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor/full-validation branch May 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants