Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(drive): state transition observability #1846

Merged
merged 21 commits into from
May 22, 2024
Merged

chore(drive): state transition observability #1846

merged 21 commits into from
May 22, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented May 14, 2024 •
edited
Loading

Issue being fixed or feature implemented

We need more transparency on state transition validation and execution process. Also, we need to add additional params to filter logs and remove extra messages to reduce noise.

What was done?

  • Added logs for check_tx
  • Refactored StateTransitionContainer to preserve the original order of state transition so we can log execution results in the same order as txs in block
  • Provided ordered single message logs for state transition processing
  • Added additional labels to check_tx metrics
  • Added metrics to state transition processing
  • Fixed reverted state transition hex

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek
lklimek previously approved these changes May 15, 2024
View reviewed changes
@shumkov shumkov changed the title chore(drive): check_tx observability chore(drive): state transition pre-validation observability May 15, 2024
@shumkov
fix: type
71efe1c
@shumkov
Merge branch 'refs/heads/v1.0-dev' into chore/drive-abci/check_tx_obs…
7bad36e 
…ervability

# Conflicts:
#	packages/rs-drive-abci/src/abci/handler/check_tx.rs
#	packages/rs-drive-abci/src/execution/check_tx/mod.rs
#	packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs
@shumkov
chore: logs and metrics for state transition processing
5236ab2
@shumkov shumkov changed the title chore(drive): state transition pre-validation observability chore(drive): state transition observability May 18, 2024
pauldelucia
pauldelucia previously approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@pauldelucia pauldelucia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

pauldelucia
pauldelucia previously approved these changes May 19, 2024
View reviewed changes
QuantumExplorer
QuantumExplorer requested changes May 22, 2024
View reviewed changes
packages/rs-drive-abci/src/abci/handler/check_tx.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/abci/handler/check_tx.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/abci/handler/check_tx.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/abci/handler/check_tx.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/execution/types/state_transition_container/v0/mod.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/execution/types/state_transition_container/v0/mod.rs Outdated Show resolved Hide resolved
packages/rs-drive-abci/src/execution/types/state_transition_container/v0/mod.rs Show resolved Hide resolved
packages/rs-drive-abci/src/execution/types/state_transition_container/v0/mod.rs Show resolved Hide resolved
...xecution/platform_events/state_transition_processing/process_raw_state_transitions/v0/mod.rs Show resolved Hide resolved
@shumkov shumkov merged commit d7b4541 into v1.0-dev May 22, 2024
27 checks passed
@shumkov shumkov deleted the chore/drive-abci/check_tx_observability branch May 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@lklimek lklimek lklimek left review comments

@pauldelucia pauldelucia pauldelucia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shumkov @lklimek @QuantumExplorer @pauldelucia