Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] "IS [NOT] UNKNOWN" syntax #705

Closed
sarahyurick opened this issue Aug 18, 2022 · 1 comment · Fixed by #719
Closed

[ENH] "IS [NOT] UNKNOWN" syntax #705

sarahyurick opened this issue Aug 18, 2022 · 1 comment · Fixed by #719
Labels
enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer

Comments

@sarahyurick
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Similar to #688. Another reason that test_boolean_operations in test_rex.py is being skipped is because DataFusion doesn't support the "IS [NOT] UNKNOWN" syntax. Now that sqlparser-rs/sqlparser-rs#583 has been merged, we are waiting on the DataFusion support.

Describe the solution you'd like
I have opened an issue on DataFusion (apache/datafusion#3195) and after that implementation is merged, we can start working on it from the Dask SQL side.

Describe alternatives you've considered
None.

Additional context
None.
@sarahyurick sarahyurick added enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer labels Aug 18, 2022
@isidentical isidentical mentioned this issue Aug 19, 2022
Closed
24 tasks
@sarahyurick sarahyurick mentioned this issue Aug 24, 2022
Merged
@charlesbluca charlesbluca linked a pull request Aug 24, 2022 that will close this issue
Support all boolean operations #719
Merged
@sarahyurick
Copy link
Collaborator Author

Closed with #719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all boolean operations sarahyurick/dask-sql
1 participant
@sarahyurick