Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for temporary workaround in autotag action #304

Open
hendrikmakait opened this issue Dec 20, 2023 · 4 comments
Open

Remove need for temporary workaround in autotag action #304

hendrikmakait opened this issue Dec 20, 2023 · 4 comments

Comments

@hendrikmakait
Copy link
Member

The Auto Tag action appears to be broken: https://github.com/dask/dask-docker/actions/runs/7228513483/job/19698075758

As a result, the latest available image is 2023.11.0, which lags behind by two releases.

@jrbourbeau
Copy link
Member

Thanks for catching @hendrikmakait. cc @jacobtomlinson @charlesbluca -- do either of you have bandwidth to look into this one?

@jrbourbeau
Copy link
Member

Okay, so #305 put in place a temporary workaround and the autotag workflow is now working again (thanks again for spotting @hendrikmakait).

Let's keep this issue open, but change the purpose to "Remove need for temporary workaround in autotag action"

@jrbourbeau jrbourbeau changed the title Auto Tag action is broken Remove need for temporary workaround in autotag action Dec 20, 2023
@charlesbluca
Copy link
Member

Thanks for the quick fix @jrbourbeau! Based on the warnings while building the autotag action:

  #9 3.732 npm WARN notsup Unsupported engine for undici@5.28.2: wanted: {"node":">=14.0"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 3.732 npm WARN notsup Not compatible with your version of node/npm: undici@5.28.2
  #9 3.732 npm WARN notsup Unsupported engine for @fastify/busboy@2.1.0: wanted: {"node":">=14"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 3.732 npm WARN notsup Not compatible with your version of node/npm: @fastify/busboy@2.1.0
  #9 3.732 npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.

I'd assume that some unpinned dependencies are now getting pulled in with a conflicting node version and causing issues, in this case undici; it's worth noting that commits have been getting pushed to master up until 9 months ago, so it's possible that this issue has already been resolved and just hasn't been pushed out in a release or tag?

@jrbourbeau
Copy link
Member

I'd assume that some unpinned dependencies are now getting pulled in with a conflicting node version and causing issues

Yeah, that seems to be what folks are talking about in the issues linked to in #305

It's been over three years since there's been a new release of ButlerLogic/action-autotag and, as you mentioned, over nine months since any commits have been added to the project. Is there another action that does the same thing and is more actively maintained? Might be time to switch to another action if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants