MAINT: raise error is no partial_fit in hyperparameter search #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrocklin
reviewed
Jun 1, 2021
| "requirement for doing incremental hyperparameter " | ||
| "optimization. For more detail, see\n\n" | ||
| " https://ml.dask.org/hyper-parameter-search.html#hyperparameter-scaling" | ||
| ) |
There was a problem hiding this comment.
Hooray for informative error messages!
Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
|
In ba8b4fe, I tried to make the header more informative. Now it reads
I think we should more clearly expose the tradeoffs of hyperparameter searches. Give me a while on that. I'm trying to resolve #838 (comment). I think it wouldn't be a bad idea to have a summary table. |
…/dask-ml into hyperparam-compat-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
It raises an error if a model is passed to an incremental hyperparameter optimization that doesn't support
partial_fit. It points to https://ml.dask.org/hyper-parameter-search.html#hyperparameter-scaling.It also tests to make sure that a passive search like
RandomizedSearchCVworks.Reference issues/PRs
This resolves #839. It doesn't solve the issue, but it makes the error more clear.