Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is Failing #11080

Closed
mrocklin opened this issue Apr 29, 2024 · 4 comments · Fixed by #11082
Closed

CI is Failing #11080

mrocklin opened this issue Apr 29, 2024 · 4 comments · Fixed by #11082
Labels
needs triage Needs a response from a contributor

Comments

@mrocklin
Copy link
Member

#11079

Alternatively, if we don't care about these runs then we should probably turn them off.

@github-actions github-actions bot added the needs triage Needs a response from a contributor label Apr 29, 2024
@mrocklin
Copy link
Member Author

@quasiben maybe this is something your team can help resolve?

@phofl
Copy link
Collaborator

phofl commented Apr 29, 2024

these started failing over the weekend because of a pytest release?

@jrbourbeau
Copy link
Member

Yeah, the latest pytest release started emitting a warning that we're elevating to a failure. They seem more related to testing setup than end-user functionality (I haven't looked deeply though)

@jrbourbeau
Copy link
Member

The first improvement listed here https://docs.pytest.org/en/stable/changelog.html#improvements is what we're seeing, I think. For example, dask.dataframe still exists when pandas isn't installed, we just raise an ImportError whenever anyone tries to use it. Pytest now warns about this (doesn't warn if ModuleNotFoundError are raised instead of ImportError)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs a response from a contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants