Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError: DataFrame are different with dask 2024.5.1 and python 3.12 #11169

Closed
dschwoerer opened this issue Jun 12, 2024 · 3 comments
Closed
Labels
needs triage Needs a response from a contributor

Comments

@dschwoerer
Copy link

dschwoerer commented Jun 12, 2024

Describe the issue:
Some unit tests fails on dask 2024.5.1

FAILED ../dataframe/io/tests/test_parquet.py::test_append[pyarrow-True] - AssertionError: DataFrame are different
FAILED ../dataframe/io/tests/test_parquet.py::test_append_wo_index[pyarrow-True] - AssertionError: DataFrame are different
FAILED ../dataframe/io/tests/test_parquet.py::test_append_known_divisions_to_unknown_divisions_works[pyarrow] - AssertionError: DataFrame are different
FAILED ../dataframe/io/tests/test_parquet.py::test_custom_filename_works_with_pyarrow_when_append_is_true - AssertionError: DataFrame are different
= 4 failed, 10489 passed, 1628 skipped, 265 xfailed, 282 xpassed, 131 warnings in 545.24s (0:09:05) =

Minimal Complete Verifiable Example:

pytest dask

Anything else we need to know?:
Full log is here

Environment:

  • Dask version: 2024.5.1
  • Python version: 3.12
  • Operating System: fedora
  • Install method (conda, pip, source): dnf / source
@github-actions github-actions bot added the needs triage Needs a response from a contributor label Jun 12, 2024
@dschwoerer dschwoerer changed the title Some unit tests fails on dask 2024.5.1 and python 3.12 AssertionError: DataFrame are different with dask 2024.5.1 and python 3.12 Jun 12, 2024
@fjetter
Copy link
Member

fjetter commented Jun 12, 2024

Can you provide a little more context to what you are doing?

Our CI is passing fine on python 3.12 and your minimal example is referencing xarray.

@dschwoerer
Copy link
Author

I am sorry about the MWE, I meant to say dask rather then xarray. I have fixed it now.

I am trying to update the dask package for fedora. As part of the build process, the test suite is run against the packages present in fedora. This is where the error is raised. I am however not sure whether this is an error in dask, and it's usage of pyarrow, or rather in pyarrow. Any help and hints would be appreciated.

@phofl
Copy link
Collaborator

phofl commented Jun 13, 2024

You installed dask-expr in version 1.1.0, we fixed the bug that causes these tests to fail in version 1.1.1, so upgrading dask-expr will work

@phofl phofl closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs a response from a contributor
Projects
None yet
Development

No branches or pull requests

3 participants