Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ghost module to overlap or some other term #3639

Closed
mrocklin opened this issue Jun 19, 2018 · 4 comments
Closed

Rename ghost module to overlap or some other term #3639

mrocklin opened this issue Jun 19, 2018 · 4 comments
Labels
good first issue Clearly described and easy to accomplish. Good for beginners to the project.

Comments

@mrocklin
Copy link
Member

This term is probably not the clearest. We should continue replacing it with something else, like overlap.

cc @jakirkham

@jakirkham
Copy link
Member

...or halo. ;) Though maybe overlap is clearer.

@ogrisel used another term that was good, but have since forgotten. Maybe he remembers?

@jakirkham
Copy link
Member

Also @jni may have thoughts here ;)

@jni
Copy link
Contributor

jni commented Jun 19, 2018

in terms of clarity, imho, overlap > halo >> ghost.

Halo makes sense if I think about it, but instinctively my mind goes to Beyoncé. =P

@mrocklin
Copy link
Member Author

This would require the following:

  1. Changing the function names within the ghost module
  2. Renaming the ghost module to overlap
  3. Changing the documentation and API documentation
  4. Including a deprecated ghost module with deprecated functions that warn and then point to the new ones

@mrocklin mrocklin added the good first issue Clearly described and easy to accomplish. Good for beginners to the project. label Jul 14, 2018
@mrocklin mrocklin closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Clearly described and easy to accomplish. Good for beginners to the project.
Projects
None yet
Development

No branches or pull requests

3 participants