Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_duplicates' subset kwarg for parity with pandas #845

Closed
cowlicks opened this issue Nov 23, 2015 · 2 comments
Closed

Add drop_duplicates' subset kwarg for parity with pandas #845

cowlicks opened this issue Nov 23, 2015 · 2 comments
Milestone

Comments

@cowlicks
Copy link
Member

Adding this makes the Distinct expression in blaze work easily. This came up while working on adding dask.dataframe to blaze in this PR. This should be pretty easy.

Relevent blaze code:
https://github.com/blaze/blaze/blob/master/blaze/compute/pandas.py#L216

Relevant dask code:
https://github.com/blaze/dask/blob/master/dask/dataframe/core.py#L244

Pandas API reference:
http://pandas.pydata.org/pandas-docs/version/0.17.0/generated/pandas.DataFrame.drop_duplicates.html

@mrocklin
Copy link
Member

Agreed that this should be pretty easy. I think you can probably just pass through the argument directly to the per-partition functions.

@mrocklin
Copy link
Member

I'll do this in about an hour if no one beats me too it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants