Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline in error message breaks intake #9813

Closed
rebecca-palmer opened this issue Jan 9, 2023 · 4 comments · Fixed by intake/intake#699
Closed

Newline in error message breaks intake #9813

rebecca-palmer opened this issue Jan 9, 2023 · 4 comments · Fixed by intake/intake#699
Labels
needs triage Needs a response from a contributor

Comments

@rebecca-palmer
Copy link

Describe the issue:

Since #9677, some dask error messages (e.g. file not found) have included a newline.

intake forwards error messages in a way that doesn't allow newlines, and hence fails its tests: failure log.

This could be fixed in dask by removing the newline (but keeping the rest of the new wording). I don't know if it could reasonably instead be fixed in intake: @martindurant

Environment:

  • Dask version: 2022.12
  • Python version: fails in both 3.10 and 3.11
  • Operating System: Ubuntu
@github-actions github-actions bot added the needs triage Needs a response from a contributor label Jan 9, 2023
@martindurant
Copy link
Member

Would be happy to fix it in intake. We can transfer the issue or perhaps close this one. Do you think you make a simple non-dask reproducer?

@jrbourbeau
Copy link
Member

Thanks for the issue @rebecca-palmer and for handling things in intake @martindurant

@rebecca-palmer
Copy link
Author

It's something I ran across in a "what breaks if we update dask" mass-rebuild: I don't actually use intake. The obvious starting point would be the code for the test that failed.

@ncclementi
Copy link
Member

From the logs, it seems the ValueError due to the new line is raised in tornado more specifically, here https://github.com/tornadoweb/tornado/blob/b726f6d66133189a1cf25a695e4e1c96d70c713b/tornado/http1connection.py#L455-L457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs a response from a contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants