Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanny.close should gracefully close worker #2779

Open
mrocklin opened this issue Jun 18, 2019 · 0 comments
Open

Nanny.close should gracefully close worker #2779

mrocklin opened this issue Jun 18, 2019 · 0 comments

Comments

@mrocklin
Copy link
Member

Currently Nanny.close just terminates the worker process. Probably it should send a close signal

future = self.rpc(self.worker_address).terminate(nanny=False)

And then wait on that future for a suitable time

with ignoring(gen.TimeoutError):
    yield gen.with_timeout(timedelta(seconds=timeout/2), future)

I'm not sure that this gets the job done though. When I tried this there were still some lingering comms around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant