Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate or overhaul Worker.set_resources #6575

Closed
crusaderky opened this issue Jun 14, 2022 · 2 comments
Closed

Deprecate or overhaul Worker.set_resources #6575

crusaderky opened this issue Jun 14, 2022 · 2 comments

Comments

@crusaderky
Copy link
Collaborator

crusaderky commented Jun 14, 2022 •
edited

Worker.set_resources, in theory, lets you change the total resources of a Worker on the fly.

In practice, it's undocumented, it's accessible exclusively from tasks or worker plugins (there's no RPC hook) and, if there are already tasks in 'constrained' state, it won't kick them off.

Should we deprecate it or should we spend time getting it into proper shape? Does anybody use this feature?
@crusaderky crusaderky mentioned this issue Jun 14, 2022
Merged
@gjoseph92
Copy link
Collaborator

Deprecation seems like a good idea.

@hendrikmakait hendrikmakait mentioned this issue Jul 6, 2022
Open
@crusaderky
Copy link
Collaborator Author

Closing as duplicate of #6677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjoseph92 @crusaderky