Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cgroups memory limit detection for cgroups V2 #6894

Closed
gjoseph92 opened this issue Aug 16, 2022 · 1 comment · Fixed by #7051
Closed

Support cgroups memory limit detection for cgroups V2 #6894

gjoseph92 opened this issue Aug 16, 2022 · 1 comment · Fixed by #7051
Labels
enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project.

Comments

@gjoseph92
Copy link
Collaborator

In cgroups v2, the memory limit changed from /sys/fs/cgroup/memory/memory.limit_in_bytes to /sys/fs/cgroup/memory.max. For example:

To fix this, let's just replace this with a loop through both files:

distributed/distributed/system.py

Line 25 in 969aa46

with open("/sys/fs/cgroup/memory/memory.limit_in_bytes") as f:

@gjoseph92 gjoseph92 added enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project. labels Aug 16, 2022
@shughes-uk
Copy link
Contributor

#7051

@gjoseph92 gjoseph92 mentioned this issue Sep 21, 2022
Merged
2 tasks
@consideRatio consideRatio mentioned this issue Feb 18, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality or make things work better good first issue Clearly described and easy to accomplish. Good for beginners to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for cgroups v2 and respect soft limits shughes-uk/distributed
2 participants
@shughes-uk @gjoseph92