Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine performance metrics: measure time spent entering/exiting thread pools #7681

Closed
crusaderky opened this issue Mar 17, 2023 · 0 comments · Fixed by #7758
Closed

Fine performance metrics: measure time spent entering/exiting thread pools #7681

crusaderky opened this issue Mar 17, 2023 · 0 comments · Fixed by #7758

Comments

@crusaderky
Copy link
Collaborator

crusaderky commented Mar 17, 2023

When investigating #7655, I got the suspicion that we may have a bottleneck caused by the fact that there's only one worker in the offload executor.
Additionally, there's a known issue (#5882) where, whenever a task calls rejoin(), you will have one less thread available then what the WorkerStateMachine believes is available, which will cause Worker.execute to get stuck for a long time on the call to run_in_executor.

In both cases, as of #7586 this time is displayed as ("execute", <prefix>, "other", "seconds").
Wrap these two calls to run_in_executor in with context_meter.meter("offload") and with context_meter.meter("executor") respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant