Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Autodetection Code #9

Closed
dasunsrule32 opened this issue Dec 17, 2018 · 1 comment
Closed

Optimize Autodetection Code #9

dasunsrule32 opened this issue Dec 17, 2018 · 1 comment
Assignees
@dasunsrule32
Labels
enhancement New feature or request

Comments

@dasunsrule32
Copy link
Owner

Need to optimize the code to autodetect the SYSFS location, reducing pipes and run less commands.

radeon-scripts/vega-fan-control

Line 22 in 9fa4656

SYSPATH=`find /sys/devices -name fan1_target 2>/dev/null | sed 's|/fan1_target||g' |head -n1` # Autodetect SYSFS path.

@dasunsrule32 dasunsrule32 self-assigned this Dec 17, 2018
@dasunsrule32 dasunsrule32 added the enhancement New feature or request label Dec 17, 2018
@dasunsrule32
Copy link
Owner Author

dasunsrule32 commented Dec 17, 2018 •
edited

This has been completed. The removed 3 pipes and using redirection now, which is less expensive and usually faster. Commit 01ecc9 adds the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasunsrule32 dasunsrule32

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dasunsrule32