Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Those changes definitely look usable. I added a few comments. Would be nice if you could address them.
package.json
Outdated
"pretest": "npm run lint", | ||
"test": "npm run test:unit", | ||
"start": "cross-env NODE_ENV=development npm-run-all -p watch start:dev", | ||
"start:dev": "cross-env NODE_V=\"$(node -v)\" NODE_ENV=development electron .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe name "start: electron"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had the same idea first. Will change.
package.json
Outdated
"test": "npm run test:unit", | ||
"start": "cross-env NODE_ENV=development npm-run-all -p watch start:dev", | ||
"start:dev": "cross-env NODE_V=\"$(node -v)\" NODE_ENV=development electron .", | ||
"watch": "webpack --watch --mode=development", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "start:watch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought changing this will make some people angry ;-)
But I agree with start:watch
.
FYI, |
@martinheidegger |
Oh right! Yes, that is an issue. We would need a |
Can we just use |
Right |
Can you rebase again (with the removed package-lock.json)? |
@martinheidegger would you mind to do this, because I don't have this cool Git software, that you have ;-) I'm pretty much done here, so if you want to make this pull request prettier in terms of commit messages, rebasing, squashing and all that stuff, that I needed to consult a manual, please go ahead! |
75667ef
to
799e5c5
Compare
Rebase looks good to me. |
I found the npm scripts a bit difficult to understand, not only from the point of view of the names, but also how they were organized.
I tried to use a scope to group them together, where the "short" command is usually the one, that contains them all.
I haven't done anything with
pack
anddist
. I didn't figure out yet, why there are 6 script entries necessary for something, that probably will be run with CI tools. I also can't think of a case, where all operating systems are built with a single run. I would suggest to reduce those to justpack
anddist
for the current OS.