feat: Support non JSON (aka binary) fetches #267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266.
Motivation
With Rest Hooks already useful for JSON type data, it should allow for other response types like images, ArrayBuffers, etc.
Solution
Sample FetchShape:
Usage:
Open questions
useResource() ensures a response, but we're still stuck with the | null union. This is needed however to have sane defaults. Currently the only distinction is based on entities, which this cannot be so would require some rethinking from normalizr design.
Perhaps a better solution is to simply allow schema to be undefined, and then take the return type of fetch.