Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @rest-hooks/react @rest-hooks/redux #2270

Merged
merged 7 commits into from
Nov 13, 2022
Merged

feat: Add @rest-hooks/react @rest-hooks/redux #2270

merged 7 commits into from
Nov 13, 2022

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Nov 12, 2022

Motivation

Clear package choice for binding options.

  • react
  • native
  • redux
  • (future: svelte, vue, etc)

Solution

  • core now contains no react references
  • rest-hooks package should look the same but opaquely does this by including the new @rest-hooks/react and adding deprecated pieces
  • Add <AsyncBoundary/> component to @rest-hooks/react

@ntucker ntucker force-pushed the feat/react branch 3 times, most recently from 34fdaed to 8c85fa1 Compare November 12, 2022 03:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #2270 (e79c685) into master (39563e9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
+ Coverage   98.22%   98.33%   +0.10%     
==========================================
  Files         118      116       -2     
  Lines        1918     1863      -55     
  Branches      285      282       -3     
==========================================
- Hits         1884     1832      -52     
+ Misses         16       13       -3     
  Partials       18       18              
Impacted Files Coverage Δ
...ages/core/src/manager/DefaultConnectionListener.ts 100.00% <ø> (ø)
packages/core/src/manager/applyManager.ts 100.00% <ø> (ø)
packages/core/src/manager/index.ts 100.00% <ø> (ø)
...kages/core/src/state/legacy-actions/createFetch.ts 100.00% <ø> (ø)
...ges/core/src/state/legacy-actions/createReceive.ts 100.00% <ø> (ø)
...ore/src/state/legacy-actions/createReceiveError.ts 100.00% <ø> (ø)
packages/core/src/state/legacy-actions/index.ts 100.00% <ø> (ø)
packages/core/src/state/selectMeta.ts 100.00% <ø> (ø)
packages/hooks/src/useCancelling.ts 100.00% <ø> (ø)
packages/legacy/src/index.ts 100.00% <ø> (ø)
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

BREAKING CHANGE: Requires rest-hooks@6.5
BREAKING CHANGE: Require @rest-hooks/react as peerdep
BREAKING CHANGE: Removed all hooks and other react exports
 - @rest-hooks/core@4.0.0
 - @rest-hooks/experimental@9.0.0
 - @rest-hooks/hooks@3.1.0
 - @rest-hooks/img@0.7.0
 - @rest-hooks/legacy@5.0.0
 - @rest-hooks/normalizr@9.3.0
 - @rest-hooks/react@0.2.0
 - @rest-hooks/redux@0.2.0
 - rest-hooks@6.6.0
 - @rest-hooks/ssr@0.4.0
 - @rest-hooks/test@8.0.0
@ntucker ntucker merged commit e79c685 into master Nov 13, 2022
@ntucker ntucker deleted the feat/react branch November 13, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants