Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tox test runner #57

Closed
brianray opened this issue May 21, 2020 · 3 comments · Fixed by #98
Closed

use tox test runner #57

brianray opened this issue May 21, 2020 · 3 comments · Fixed by #98
Labels
enhancement New feature or request question Further information is requested

Comments

@brianray
Copy link
Member

https://tox.readthedocs.io/en/latest/

@brianray brianray added enhancement New feature or request question Further information is requested Stability / Quality labels May 21, 2020
@brianray
Copy link
Member Author

@terrytangyuan good to get your feedback on tox

@brianray
Copy link
Member Author

Little unclear if we need to put Python version in requirements.txt https://github.com/brianray/data-describe/blob/master/requirements.txt#L1
I suggest we also take that out.

TODO:

  • create tox.ini
  • add python instructions to README (if not there)
  • remove explicit "python" version in requirements.txt

@terrytangyuan
Copy link
Contributor

No, we should not have Python version in requirements.txt. However, we should explicitly specify the range of Python versions we support, an example here: https://github.com/tensorflow/io/blob/6505a6e6a6fd4e20bbdc09831a1489f4d26dbed2/setup.py#L137

Regarding tox, a couple of thoughts:

  • Tox is definitely good for local testing.
  • We are already building automated testing via GitHub Actions and can run multiple builds for different Python versions.
  • If we decide to run only one build on GitHub Actions via tox for multiple Python versions, tox might be more efficient as it might be able to leverage cache across various tests in a single build. GitHub Actions have ability to store cache as well but there might still be some additional overhead to spin up multiple builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants