Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect Close to be called #15

Closed
karlkfi opened this issue Apr 1, 2015 · 2 comments · Fixed by #21
Closed

Expect Close to be called #15

karlkfi opened this issue Apr 1, 2015 · 2 comments · Fixed by #21
Labels
enhancement
Milestone
1.0.0

Comments

@karlkfi
Copy link

karlkfi commented Apr 1, 2015

It'd be nice if the mock rows struct would expect Close() to be called, either by default or with an ExpectClose() enabler. Most of the time the closing is deferred, but we want to test that it happens.
@l3pp4rd
Copy link
Member

l3pp4rd commented Apr 13, 2015

sounds reasonable, will have a look when I have some time

@l3pp4rd l3pp4rd added this to the Abeloth milestone Apr 13, 2015
@l3pp4rd
Copy link
Member

l3pp4rd commented Jun 28, 2015

since this will not be backward compatible, will add this to the milestone, should go with a version change

l3pp4rd added a commit that referenced this issue Jul 17, 2015
@l3pp4rd
concurrency support, closes #20 and closes #9 and closes #15
ddc9348
@l3pp4rd l3pp4rd mentioned this issue Jul 17, 2015
Merged
10 tasks
l3pp4rd added a commit that referenced this issue Aug 28, 2015
@l3pp4rd
concurrency support, closes #20 and closes #9 and closes #15
a071483 
* c600769 do not require a connection name, unique dsn is generated
* 1b20b9c update travis
* 1097b6a add comments for godoc documentation
* c142a95 fix golint reported issues
l3pp4rd added a commit that referenced this issue Aug 28, 2015
@l3pp4rd
Merge pull request #21 from DATA-DOG/refactor
711064c 
concurrency support, closes #20 and closes #9 and closes #15
@retnuh retnuh mentioned this issue Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

concurrency support, closes #20 and closes #9 and closes #15 DATA-DOG/go-sqlmock
2 participants
@l3pp4rd @karlkfi