ExpectQuery in prepared statement fails if the argument is "2" ( or, putatively greater than 1)

[luistm]

Hi ,

The following test will fail:

package main

import (
	"database/sql"
	"fmt"
)

func testFunction(db *sql.DB) {
	stmt, err := db.Prepare("SELECT id FROM test WHERE id=$1")

	if err != nil {
		fmt.Println(err)
	}

	stmt.QueryRow("2")

	stmt.Close()

}

func main() {}

package main

import (
	"testing"

	"github.com/stretchr/testify/assert"
	sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
)

func TestPrepare(t *testing.T) {
	db, mock, mErr := sqlmock.New()
	assert.NoError(t, mErr)
	defer db.Close()

	mock.ExpectPrepare("^SELECT id FROM test WHERE id=\\$1$")
	mock.ExpectQuery("2")

	testFunction(db)

	if err := mock.ExpectationsWereMet(); err != nil {
		t.Errorf("there were unfulfilled expections: %s", err)
	}

}

If i replace the code with

mock.ExpectQuery("1")

and

stmt.QueryRow("1")

everything runs as expected.

I'm i doing something wrong?

Thanks

[l3pp4rd]

Yes, you are not doing it right in this case. The previous issue was valid, this isn't.

There are two ways, one to expect the query on that statement (which is more straightforward)

package main

import (
    "testing"

    "github.com/stretchr/testify/assert"
    sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
)

func TestPrepare(t *testing.T) {
    db, mock, mErr := sqlmock.New()
    assert.NoError(t, mErr)
    defer db.Close()

    mock.ExpectPrepare("^SELECT id FROM test WHERE id=\\$1$").ExpectQuery().WithArgs("2")

    testFunction(db)

    if err := mock.ExpectationsWereMet(); err != nil {
        t.Errorf("there were unfulfilled expections: %s", err)
    }
}

or make a next expectation for query, by repeating the query string

package main

import (
    "testing"

    "github.com/stretchr/testify/assert"
    sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
)

func TestPrepare(t *testing.T) {
    db, mock, mErr := sqlmock.New()
    assert.NoError(t, mErr)
    defer db.Close()

        mock.ExpectPrepare("^SELECT id FROM test WHERE id=\\$1$")
    mock.ExpectQuery("^SELECT id FROM test WHERE id=\\$1$").WithArgs("2")

    testFunction(db)

    if err := mock.ExpectationsWereMet(); err != nil {
        t.Errorf("there were unfulfilled expections: %s", err)
    }
}

[l3pp4rd]

see tests for more details or have a look in godoc

[luistm]

Works like a charm! 👍
Thanks for enlightening me.