Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject Reason should not be editable when the share is already approved #1290

Closed
TejasRGitHub opened this issue May 20, 2024 · 1 comment · Fixed by #1277
Closed

Reject Reason should not be editable when the share is already approved #1290

TejasRGitHub opened this issue May 20, 2024 · 1 comment · Fixed by #1277

Comments

@TejasRGitHub
Copy link
Contributor

Is your idea related to a problem? Please describe.
While rejecting a share, the dataset owner / steward can add in a rejection reason.

When the dataset is approved, this field can still be updated and edited.

Describe the solution you'd like
After the dataset is approved, the reject reason field should not be editable

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

@SofiaSazonova
Copy link
Contributor

It's covered in this PR

@SofiaSazonova SofiaSazonova added this to To do in v2.6.0 via automation Jun 10, 2024
@SofiaSazonova SofiaSazonova linked a pull request Jun 10, 2024 that will close this issue
@SofiaSazonova SofiaSazonova moved this from To do to Review in progress in v2.6.0 Jun 10, 2024
@SofiaSazonova SofiaSazonova moved this from To do to Review in progress in v2.6.0 Jun 10, 2024
@SofiaSazonova SofiaSazonova moved this from To do to Review in progress in v2.6.0 Jun 10, 2024
v2.6.0 automation moved this from Review in progress to Done Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants