-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
road segment infra - improvements #2567
Comments
Hi @atalyaalon , |
Hi @atalyaalon |
as discussed we don't need it to have both in the query. What we might need is to make sure road1 is in "location_info" and in "news_flash" object, since the road1 (and also road_segment_name) is used in titles for example |
as discussed, yes, we don't want to query by road_segment_name, only by id |
Hi @atalyaalon , |
PR (#2641) closed this issue. |
Ziv, awesome work with the road segments infra (that includes junctions of course)
Following both this pr and this one
I think we should:
Is it possible, for example, that we're missing a certain widget that does not use "get_expression_for_road_segment_location_fields" in one of the queries and hence we don't use the junctions data?
(@ziv17 I know you've made a very thorough work - adding it to get_query function for example - but wondering how can we make sure we don't forget it in the next widget we're creating (it can also be by having a documentation on how to construct a query and not by code)
Of course we need to consider different queries that are a part of the code but do not filter the segment for some reason (for example, in head_on_collisions_comparison_widget.py we have a query of all roads in Israel - hence we don't filter the road segment there)
The text was updated successfully, but these errors were encountered: