Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Location Accuracy in Widgets queries #2604

Closed
atalyaalon opened this issue Apr 13, 2024 · 4 comments · Fixed by #2641
Closed

Filter Location Accuracy in Widgets queries #2604

atalyaalon opened this issue Apr 13, 2024 · 4 comments · Fixed by #2641
Assignees

Comments

@atalyaalon
Copy link
Collaborator

atalyaalon commented Apr 13, 2024

In Urban Widgets queries: only location_accuracy = 1 (עיגון מדויק) OR location_accuracy = 3 (מרכז דרך)
In Sub-Urban queries: only location_accuracy = 1 (עיגון מדויק) OR location_accuracy = 4 (מרכז קילומטר)

Perhaps these queries should be a part of our "queries infrastructure", just like filtering a sub-urban segment query (with junctions as well) is a part of the infrastructure.

@ziv17
Copy link
Collaborator

ziv17 commented Apr 18, 2024

Hi @atalyaalon , will this be also correct for urban and sub-urban junctions when we will add them?

@ziv17
Copy link
Collaborator

ziv17 commented Apr 20, 2024

Hi @atalyaalon , actually, this should go by the resolution, rather then by the widget, right? The only difference is with all_location_widget.

@atalyaalon
Copy link
Collaborator Author

Hi @atalyaalon , will this be also correct for urban and sub-urban junctions when we will add them?

yes

@atalyaalon
Copy link
Collaborator Author

Hi @atalyaalon , actually, this should go by the resolution, rather then by the widget, right? The only difference is with all_location_widget.

@ziv17 yes, but of course it affects the widget's data. But yes by the resolution we can set the location accuracy filters when calculating the cache.

@atalyaalon atalyaalon linked a pull request May 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants