-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage handouts #30
Comments
@drjwbaker Do you want to add to this issue that we would like the handouts created as well? I think we should let people make handouts based on the lessons.I will put 'create handouts' as another sprint job in the README. |
@weaverbel I'd leave it as down to the lesson maintainers. I'm seeing @jt14den this week, so I'll speak to him about maintaining shell handout (I tend to use one and have a starting point that can be used for this). |
How is this for instructor notes on making a handout? http://data-lessons.github.io/library-data-intro/guide/ Comments from other lesson maintainers appreciated @ccronje @weaverbel @ostephens @mkuzak @jezcope |
@drjwbaker looks good |
My idea is that dillinger is not a permanent solution but much much easier than enforcing pandoc. Is people have other ideas, great! |
See Shell lesson as potential model to build on data-lessons/library-shell-DEPRECATED#34 |
Discussion of potential alternatives at data-lessons/library-shell-DEPRECATED#34 Consolidate discussion here. |
We can automatically generate a handout from the key points listed in the header of each episode to create a printable page (and then use conditional CSS to format it differently if so desired) - see https://gvwilson.github.io/handout-example/handout/ for an example of what would be included for the example lesson. |
@gvwilson I found yesterday, however, that I can't put regex in keypoints as it breaks the formatting of the header. |
(or indeed any shell code) |
Should be fixable (probably just using the wrong escape pipe) - can you please file an issue in the lesson example repo and we'll ask @rgaiacs to find a solution? Assuming it's fixable, is a keypoints-based solution acceptable, or are there other things a handout would need? Diagrams immediately come to mind... |
@jt14den Do you still intend to raise this issue as discussed in handover? |
@drjwbaker didn't have time to yesterday, but will now. I wanted to see what it was doing locally first. |
@drjwbaker I can't replicate the problem. I added some of the regex expressions from the Is there another regex that you were working from that didn't work? |
@jt14den Huh. That is odd. My bad. I'll take another look. |
@drjwbaker I think
doesn't help the reader since is just commands without any information about what they do. The only two issues that I could spot are
|
@jt14den See https://github.com/data-lessons/library-data-intro/blob/gh-pages/_episodes/04-regular-expressions.md " |
@rgaiacs The sort of info we'd want in the handout - so expressed via the keypoints - are the lines at http://data-lessons.github.io/library-data-intro/reference/ |
(I agree what you have above doesn't help the learner. What we want is a cheat sheet) |
Fixing this now so the broken header doesn't stay up. This data-lessons/library-data-intro-DEPRECATED@a539510 is the formatting of the header with "[] defines a range of characters" that breaks. |
@rgaiacs that was just for testing purposes, not what we want as @drjwbaker indicates. I was trying to find what breaks the template. @rgaiacs see above. It looks like [] breaks the header. I can try it soon and make an issue. |
@drjwbaker and @rgaiacs it's not the
That breaks the keypoints. It will also break if you use the github markdown way of creating sub-lists (two spaces in)
@drjwbaker are sub-lists essential in creating handouts? If so, anyway of making that possible @rgaiacs ? |
@jt14den YAML supports two syntax for lists. The first one is
and the second one is
The first one is "preferable" for aesthetic reasons. But the second allows you to have nested lists. You can also have nested lists with the first syntax but you need to use a "hack" as explained in StackOverflow. I would suggest to avoid nest lists just because it should break the Liquid code that is rendering the key points. |
I wasn't trying to make a sublist. Just a list. As far as I can see I did not indent the text or use more than one "-". @jt14den: can you push an update with the line I tried to add please? |
@rgaiacs thanks for that info! @drjwbaker sorry! I mis-read the diff. You need to quote the keypoint if you are including regexes and other characters. |
Added the regex key point on the data-lessons/library-data-intro-DEPRECATED#44 PR. It works! https://data-lessons.github.io/library-data-intro/04-regular-expressions/ |
I @jt14den spoke too soon :( Right. I think it is backslash that kills the header formatting. See data-lessons/library-data-intro-DEPRECATED@c8e49e0. Having tested, I'm pretty sure it is the line..
..that is the problem, and any line with a backslash in particular. Can someone else test and report back please? |
Looks like you've figured it out already but you can just escape it with a double slash! " |
We have a winner! I hadn't figured that out, so thanks @alexandermendes! |
It works! Man this template is a faff sometimes. Next step in managing handouts, how do we propose turning http://data-lessons.github.io/library-data-intro/reference/ into a nicely formatted handout? |
@drjwbaker I didn't tested but you could try replace https://github.com/data-lessons/library-data-intro/blob/gh-pages/_includes/episode_keypoints.html#L8, i.e.
with
|
Sorry @drjwbaker for closing too soon. Thanks @rgaiacs for the markdownify approach. |
Referring to data-lessons/library-openrefine-DEPRECATED#60 (comment) ensure that:
The text was updated successfully, but these errors were encountered: