Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialisation shapes are inconsistent #192

Closed
dsteinberg opened this issue Aug 17, 2018 · 1 comment
Closed

Initialisation shapes are inconsistent #192

dsteinberg opened this issue Aug 17, 2018 · 1 comment
Labels
Milestone

Comments

@dsteinberg
Copy link
Contributor

  • we have swapped n_in, n_out in initialisers.py, our 2-d weights are typically (n_out, n_in)
  • we need to generalize these functions to more than 2-dim matrices, see the conv layers

There may be a better design here that keeps track of these dimensions... i.e. functions like sample_W in layers.py are horrible!

@dsteinberg dsteinberg added the bug label Aug 17, 2018
@dsteinberg dsteinberg added this to the Release 0.9 milestone Aug 17, 2018
@dsteinberg
Copy link
Contributor Author

dsteinberg commented Aug 17, 2018

This also should fix the autonorm initialization, see d25947e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant