Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50% of work is copying from C++ to Python when there are many matches #79

Closed
unzvfu opened this issue Apr 11, 2018 · 1 comment
Closed
Assignees

Comments

@unzvfu
Copy link

unzvfu commented Apr 11, 2018

The code

        for j in range(matches):
            ind = c_indices[j]
            assert ind < len(filters2)
            result.append((i, c_scores[j], ind))

at entitymatcher.py:93 is responsible for over 50% of the work when there are many matches (e.g. large k ~ len(filters2) and small(ish) threshold ~ 0.5).

This could be (partly) resolved by a solution to issue #67. (Issue #66 is also relevant.)

@unzvfu
Copy link
Author

unzvfu commented May 3, 2018

Fixed in #101.

@unzvfu unzvfu closed this as completed May 3, 2018
@hardbyte hardbyte added this to the Sprint 2018-04-23 milestone May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants