Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

listState.update in #ListStateBenchmark#listAdd? #47

Open
Jiayi-Liao opened this issue Dec 23, 2019 · 2 comments
Open

listState.update in #ListStateBenchmark#listAdd? #47

Jiayi-Liao opened this issue Dec 23, 2019 · 2 comments

Comments

@Jiayi-Liao
Copy link

Jiayi-Liao commented Dec 23, 2019

https://github.com/dataArtisans/flink-benchmarks/blob/master/src/main/java/org/apache/flink/state/benchmark/ListStateBenchmark.java#L119

This is introduced in PR#13.

Shouldn't this be listState.add ?

Please correct me if I'm wrong. Thanks.

cc @carp84

@Jiayi-Liao Jiayi-Liao changed the title Bug in ListStateBenchmark? listState.update in #ListStateBenchmark#listAdd? Dec 24, 2019
@carp84
Copy link
Contributor

carp84 commented Dec 24, 2019

The existing listAdd benchmark is in accordance with the semantic of add benchmarks for MapState and ValueState, meaning the "insert value for new key" scenario.

However, since there's a specific add interface for AppendingState, I agree it's necessary to add another benchmark for ListState. How about we name the new benchmark as listAppend? Would you like to submit a PR for it? @buptljy Thanks.

@Jiayi-Liao
Copy link
Author

Jiayi-Liao commented Dec 24, 2019

@carp84 Thanks for your explaination.
+1 for adding a new benchmark for ListState.add. I'll submit a PR soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants