You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
The existing listAdd benchmark is in accordance with the semantic of add benchmarks for MapState and ValueState, meaning the "insert value for new key" scenario.
However, since there's a specific add interface for AppendingState, I agree it's necessary to add another benchmark for ListState. How about we name the new benchmark as listAppend? Would you like to submit a PR for it? @buptljy Thanks.
https://github.com/dataArtisans/flink-benchmarks/blob/master/src/main/java/org/apache/flink/state/benchmark/ListStateBenchmark.java#L119
This is introduced in PR#13.
Shouldn't this be
listState.add
?Please correct me if I'm wrong. Thanks.
cc @carp84
The text was updated successfully, but these errors were encountered: