Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE] Possible duplicate class for WebHook #441

Open
aaravind100 opened this issue Nov 14, 2023 · 1 comment
Open

[ISSUE] Possible duplicate class for WebHook #441

aaravind100 opened this issue Nov 14, 2023 · 1 comment
Labels
OpenAPI issues related to metadata across all SDKs

Comments

@aaravind100
Copy link

Description
The WebhookNotificationsOnDurationWarningThresholdExceededItem class is a possible duplicate of Webhook. Both takes a webhook destination id as input.

Removing the duplicate would make the options for WebhookNotifications consistent to be List[WebHook], just on_duration_warning_threshold_exceeded is different compared to the other options.

Other Information

  • OS: Linux Ubuntu 22.04.3 LTS (WSL)
  • Version: 0.12.0
@mgyucht
Copy link
Contributor

mgyucht commented Jan 3, 2024

Thanks for raising this! We will be doing a review of all dataclasses across all SDKs and try to remove these duplicate structures in the coming months.

@mgyucht mgyucht added the OpenAPI issues related to metadata across all SDKs label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OpenAPI issues related to metadata across all SDKs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgyucht @aaravind100