Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace import method name #91

Closed
AdeelK93 opened this issue May 3, 2023 · 2 comments
Closed

Workspace import method name #91

AdeelK93 opened this issue May 3, 2023 · 2 comments

Comments

@AdeelK93
Copy link

AdeelK93 commented May 3, 2023

Hello! I'm wondering why the import_ method has a trailing underscore, but export doesn't - was that intentional?

@nfx
Copy link
Contributor

nfx commented May 3, 2023

@AdeelK93 yes, because import is a reserved Python keyword 🤷 what would be more logical suffix here?

image

@AdeelK93
Copy link
Author

AdeelK93 commented May 3, 2023

Oh! Hmm. To me the _ implied that this was a private method in some way, which gave me pause when first trying it out.

But maybe I'm alone in that concern, and I don't have a better suggestion either

@AdeelK93 AdeelK93 closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants