New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements delete() for Index #1165
Conversation
Now we have some problem with MultiIndex related with adding default index like below.
>>> sdf = _InternalFrame.attach_default_index(
... sdf, default_index_type='distributed-sequence')
Traceback (most recent call last):
...
raise TypeError("Unsupported type in conversion to Arrow: " + str(dt))
TypeError: Unsupported type in conversion to Arrow: StructType(List(StructField(__index_level_0__,StringType,false),StructField(__index_level_1__,StringType,false)))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
...
NotImplementedError: Invalid returnType with grouped map Pandas UDFs: StructType(List(StructField(__index_level_0__,LongType,true),StructField(__index_value__,StructType(List(StructField(__index_level_0__,StringType,false),StructField(__index_level_1__,StringType,false))),false))) is not supported so explicitly doesn't support for now. |
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 92.83% 95.02% +2.18%
==========================================
Files 34 34
Lines 7944 7961 +17
==========================================
+ Hits 7375 7565 +190
+ Misses 569 396 -173
Continue to review full report at Codecov.
|
Seems okay otherwise. |
@itholic, can you resolve conflicts? |
@HyukjinKwon i did :) |
Softagram Impact Report for pull/1165 (head commit: 8f78dc8)
|
@HyukjinKwon Yeah, I'm fixing those things you commented. Thanks for the remind :) |
@itholic looks you made a mistake during rebasing the branch .. |
@HyukjinKwon Right. I'm fixing now 😭 |
I fixed but It seems that there is some problem in CI with conda. |
I'm taking a look at the conda build. |
@itholic The build must be fixed, maybe we should push another commit to cleanup the checks. |
Thanks for the notice! I just pushed an empty commit :) |
I'm wondering how to restart the checks cleanly. haha |
Oh, It seems that re-run the Actions is allowed for the repository owner in the Actions page. (the screenshot was captured in my forked repository) |
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 94.17% 94.18% +0.01%
==========================================
Files 38 38
Lines 8553 8570 +17
==========================================
+ Hits 8055 8072 +17
Misses 498 498
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
@HyukjinKwon Thanks! |
@itholic can you rebase this please? |
@HyukjinKwon Yup, pending tests. |
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Index.delete.html#pandas.Index.delete