Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 2.0.0 + ScalaTest 3.0.0 + updates sbt plugins #54

Merged

Conversation

jaceklaskowski
Copy link
Contributor

The subject says it all.

WARNING: doit works (since it disabled tests in assembly), but I could not get sbt test working. It fails with the following error which is more about TensorFlow that I know nothing about:

➜  tensorframes git:(spark-200-and-other-upgrades) sbt
[info] Loading global plugins from /Users/jacek/.sbt/0.13/plugins
[info] Loading project definition from /Users/jacek/dev/oss/tensorframes/project
[info] Set current project to tensorframes (in build file:/Users/jacek/dev/oss/tensorframes/)
> testOnly org.tensorframes.dsl.BasicOpsSuite
16/08/04 23:52:22 DEBUG Paths$: Request for x -> 0
16/08/04 23:52:22 DEBUG Paths$: Request for y -> 0
16/08/04 23:52:22 DEBUG Paths$: Request for z -> 0

import tensorflow as tf

x = tf.constant(1, name='x')
y = tf.constant(2, name='y')
z = tf.add(x, y, name='z')

g = tf.get_default_graph().as_graph_def()
for n in g.node:
    print ">>>>>", str(n.name), "<<<<<<"
    print n

[info] BasicOpsSuite:
[info] - Add *** FAILED ***
[info]   1 did not equal 0 (1,===========
[info]   
[info]   import tensorflow as tf
[info]   
[info]   x = tf.constant(1, name='x')
[info]   y = tf.constant(2, name='y')
[info]   z = tf.add(x, y, name='z')
[info]         
[info]   g = tf.get_default_graph().as_graph_def()
[info]   for n in g.node:
[info]       print ">>>>>", str(n.name), "<<<<<<"
[info]       print n
[info]          
[info]   ===========) (ExtractNodes.scala:40)
[info] Run completed in 1 second, 772 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 0, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error]         org.tensorframes.dsl.BasicOpsSuite
[error] (test:testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 2 s, completed Aug 4, 2016 11:52:22 PM

I'm proposing the PR hoping the issue is a minor one that could easily be fixed with enough guidance.

@jaceklaskowski
Copy link
Contributor Author

Hi @thunterdb, mind reviewing the changes (and perhaps committing them to repo)? I'd appreciate.

@thunterdb
Copy link
Contributor

Thanks a lot for the PR! I will take a look at it this week and check why
the test is breaking.

On August 8, 2016 at 6:54:29 PM, Jacek Laskowski (notifications@github.com)
wrote:

Hi @thunterdb https://github.com/thunterdb, mind reviewing the changes
(and perhaps committing them to repo)? I'd appreciate.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHPjAdZhepbb9_hBJ-eGEO4xaAO3DTALks5qd93UgaJpZM4JdKPA
.

@thunterdb
Copy link
Contributor

@jaceklaskowski it looks like you do not have the tensorflow python package installed on your development machine. It is called by the scala tests to check for correctness against the official python binding. These tests have run successfully on jenkins though, so it looks good.

Merging, thanks for the cleanups!

@thunterdb thunterdb merged commit df68cea into databricks:master Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants