Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time string for interval should support both seconds and second #100

Closed
ronanstokes-db opened this issue Jan 26, 2022 · 0 comments · Fixed by #112
Closed

time string for interval should support both seconds and second #100

ronanstokes-db opened this issue Jan 26, 2022 · 0 comments · Fixed by #112
Assignees
@ronanstokes-db

Comments

@ronanstokes-db
Copy link
Contributor

Expected Behavior

Time intervals can be specified as "12 minutes, 2 seconds". You can also specify "1 minute, 2 seconds". You should be able to specify "1 minute 1 second"

Current Behavior

"1 minute 1 seconds" works but "1 minute 1 second" does not

Steps to Reproduce (for bugs)

Will add test case with bug fix

Context

Your Environment

  • dbldatagen version used: 0.2.0 RC0
  • Databricks Runtime version:
  • Cloud environment used:
@ronanstokes-db ronanstokes-db self-assigned this Jan 26, 2022
@ronanstokes-db ronanstokes-db linked a pull request Oct 4, 2022 that will close this issue
fixed use of time strings to allow both seconds and second etc #112
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronanstokes-db ronanstokes-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed use of time strings to allow both seconds and second etc databrickslabs/dbldatagen
1 participant
@ronanstokes-db