Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict KMS policy to caller AWS account #1309

Merged
merged 2 commits into from
May 12, 2022
Merged

Restrict KMS policy to caller AWS account #1309

merged 2 commits into from
May 12, 2022

Conversation

amine250
Copy link
Contributor

Current KMS policy is too large allowing all actions by any AWS account. Restrict it to the caller AWS account.

@amine250
Restrict KMS policy to caller AWS account
3501b16 
Current KMS policy is too large allowing all actions by any AWS account. Restrict it to the caller AWS account.
@alexott alexott requested a review from nkvuong May 12, 2022 10:05
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited

Codecov Report

Merging #1309 (3501b16) into master (24ed7fd) will not change coverage.
The diff coverage is n/a.

❗ Current head 3501b16 differs from pull request most recent head 686fac5. Consider uploading reports for the commit 686fac5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         118      118           
  Lines       10001    10001           
=======================================
  Hits         9061     9061           
  Misses        559      559           
  Partials      381      381

nkvuong
nkvuong requested changes May 12, 2022
View reviewed changes
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update this for CMK for workspace storage (line 97)

nkvuong
nkvuong approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfx nfx merged commit f8c02ef into databricks:master May 12, 2022
@nfx nfx mentioned this pull request May 20, 2022
Merged
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@amine250
Restrict KMS policy to caller AWS account (databricks#1309)
eee882b 
Current KMS policy is too large allowing all actions by any AWS account. Restrict it to the caller AWS account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkvuong nkvuong nkvuong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amine250 @nkvuong @nfx