Clarify optionality of databricks_mws_workspaces.deployment_name in docs and examples
#1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easel
changed the title
nfx
requested changes
May 17, 2022
nfx
changed the title
deployment_name attribute of databricks_mws_workspaces in docs and examples
nfx
changed the title
deployment_name attribute of databricks_mws_workspaces in docs and examplesdatabricks_mws_workspaces.deployment_name in docs and examples
nfx
reviewed
May 18, 2022
nfx
approved these changes
May 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 90.60% 90.60%
=======================================
Files 118 118
Lines 10001 10001
=======================================
Hits 9061 9061
Misses 559 559
Partials 381 381 |
|
Thanks for the merge! |
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…in docs and examples (databricks#1315) * Drop deployment_name from aws-workspaces worked example * Reflect optionality in references to deployment_name * Apply suggestions from code review Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314