Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #323 - add DiffSuppressFunc for legacy conf #334

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Fix #323 - add DiffSuppressFunc for legacy conf #334

merged 3 commits into from
Sep 24, 2020

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Sep 22, 2020

No description provided.

@nfx nfx linked an issue Sep 22, 2020 that may be closed by this pull request
[ISSUE] databricks_job resources are always updated even when no changes #323
Closed
@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 27ffa180-fceb-11ea-a56a-67316b5b87cd

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020 •
edited

Codecov Report

Merging #334 into master will decrease coverage by 0.14%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   64.69%   64.54%   -0.15%     
==========================================
  Files          55       55              
  Lines        6225     6239      +14     
==========================================
  Hits         4027     4027              
- Misses       1831     1843      +12     
- Partials      367      369       +2
Impacted Files Coverage Δ
compute/resource_cluster.go 74.88% <0.00%> (-2.57%) ⬇️
compute/resource_job.go 73.21% <12.50%> (-2.37%) ⬇️

@nfx nfx mentioned this pull request Sep 22, 2020
Closed
alexott
alexott approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, with small comment about code duplication

compute/resource_job.go Show resolved Hide resolved
@alexott alexott mentioned this pull request Sep 23, 2020
Merged
stikkireddy
stikkireddy reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@stikkireddy stikkireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the behavior of the jobs apis are not consistent across azure and aws. LGTM for now this should resolve that but probably should see if we remove these returns from api calls.

compute/resource_job.go Show resolved Hide resolved
compute/resource_job.go Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c509eac0-fdb9-11ea-a706-8f9ec0eccd66

@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 956e5460-fe61-11ea-803e-573615702161

@nfx nfx merged commit d5ff769 into master Sep 24, 2020
@nfx nfx deleted the fix/323 branch September 24, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stikkireddy stikkireddy stikkireddy left review comments

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_job resources are always updated even when no changes
5 participants
@nfx @TravisBuddy @codecov-commenter @alexott @stikkireddy