added support for other azure cloud environments #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 80.84% 80.91% +0.07%
==========================================
Files 63 63
Lines 6013 6037 +24
==========================================
+ Hits 4861 4885 +24
Misses 760 760
Partials 392 392
|
This was
linked to
issues
Dec 9, 2020
added 2 commits
December 9, 2020 13:19
- removed the handling of the arm environment from env.go - use a private property in AzureAuth to get arm environment - updated documentation
nfx
requested changes
Dec 9, 2020
nfx
approved these changes
Dec 9, 2020
|
@kankomi feature is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issues #434 and #391.
This is my first PR so feedback is very welcome.