Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global rate limit to HTTP calls #465

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Add global rate limit to HTTP calls #465

merged 2 commits into from
Jan 24, 2021

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jan 24, 2021

Fixes #156

@nfx nfx requested a review from alexott January 24, 2021 13:59
@nfx nfx self-assigned this Jan 24, 2021
@codecov
Copy link

codecov bot commented Jan 24, 2021 •
edited

Codecov Report

Merging #465 (089cb08) into master (dacd91d) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   81.26%   81.27%           
=======================================
  Files          68       68           
  Lines        5236     5249   +13     
=======================================
+ Hits         4255     4266   +11     
- Misses        660      661    +1     
- Partials      321      322    +1
Impacted Files Coverage Δ
common/http.go 85.76% <0.00%> (-0.64%) ⬇️
common/client.go 83.89% <100.00%> (+0.42%) ⬆️
provider/provider.go 93.35% <100.00%> (+0.20%) ⬆️

alexott
alexott approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

common/client.go Outdated Show resolved Hide resolved
@nfx nfx merged commit e29d6f2 into master Jan 24, 2021
@nfx nfx deleted the feature/156 branch January 24, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees

@nfx nfx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Add global rate limit to API calls
2 participants
@nfx @alexott