Update Customer Managed Keys & MWS workspace to match new API #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due the changes in the Accounts API we need to do following changes: * Add required attribute `use_cases` to `databricks_mws_customer_managed_keys` resource * The `customer_managed_key_id` field in `databricks_mws_workspaces` resource is deprecated and should be replaced with `managed_services_customer_managed_key_id` (and optionally `storage_customer_managed_key_id`). The `customer_managed_key_id` field is left for compatibility, and automatically converted into `managed_services_customer_managed_key_id`. It will be completely removed in the next versions This fixes #641
alexott
force-pushed
the
cmk-fixes-new-api
branch
from
70d496b
to
27b6916
Compare
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
+ Coverage 82.95% 82.98% +0.02%
==========================================
Files 85 85
Lines 7803 7816 +13
==========================================
+ Hits 6473 6486 +13
Misses 859 859
Partials 471 471
|
nfx
approved these changes
May 12, 2021
|
thank you for picking this up |
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…icks#642) Due the changes in the Accounts API we need to do following changes: * Add required attribute `use_cases` to `databricks_mws_customer_managed_keys` resource * The `customer_managed_key_id` field in `databricks_mws_workspaces` resource is deprecated and should be replaced with `managed_services_customer_managed_key_id` (and optionally `storage_customer_managed_key_id`). The `customer_managed_key_id` field is left for compatibility, and automatically converted into `managed_services_customer_managed_key_id`. It will be completely removed in the next versions This fixes databricks#641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due the changes in the Accounts API we need to do following changes:
use_casestodatabricks_mws_customer_managed_keysresourcecustomer_managed_key_idfield indatabricks_mws_workspacesresource is deprecated and should be replaced withmanaged_services_customer_managed_key_id(and optionallystorage_customer_managed_key_id). Thecustomer_managed_key_idfield is left for compatibility, and automatically converted intomanaged_services_customer_managed_key_id. It will be completely removed in the next versionsThis fixes #641