add resource_directory #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 83.41% 83.49% +0.08%
==========================================
Files 86 87 +1
Lines 7939 7979 +40
==========================================
+ Hits 6622 6662 +40
Misses 839 839
Partials 478 478
|
nfx
requested changes
Jun 18, 2021
| notebooksAPI := NewNotebooksAPI(ctx, c) | ||
| path := d.Get("path").(string) | ||
| if err := notebooksAPI.Mkdirs(path); err != nil { | ||
| // TODO: handle RESOURCE_ALREADY_EXISTS |
There was a problem hiding this comment.
For directory you probably have to remove this todo
There was a problem hiding this comment.
I think it still needs to be handled. If we try to create the path /a/b/c but a/b is already a notebook or other type of object it will fail.
|
Hi, @nfx . Just to be sure, are you ok with the
|
|
Will add documentation later as well. |
psg2
force-pushed
the
feat/add-directory-resource
branch
from
85b8953
to
e57f60f
Compare
nfx
approved these changes
Jun 22, 2021
| directory_path = "/Production/ETL" | ||
| depends_on = [databricks_notebook.this] | ||
| directory_path = databricks_directory.this.path | ||
| depends_on = [databricks_directory.this] |
There was a problem hiding this comment.
Depends_on is not needed as long as there's an explicit dependency.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #672