Add functionality to restart always running jobs #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 83.49% 83.56% +0.06%
==========================================
Files 87 87
Lines 8015 8060 +45
==========================================
+ Hits 6692 6735 +43
- Misses 842 843 +1
- Partials 481 482 +1
|
alexott
reviewed
Jul 8, 2021
| @@ -573,7 +573,9 @@ func (j Job) ID() string { | |||
|
|
|||
| // RunParameters ... | |||
| type RunParameters struct { | |||
| // TODO: if we add job_id, it can be also a request to RunNow | |||
| // a shortcut field to reuse this type for RunNow | |||
| JobID int64 `json:"job_id,omitempty"` | |||
There was a problem hiding this comment.
should it be tf:"computed" ?
There was a problem hiding this comment.
this entity is not exposed to TF - just internal comms
compute/resource_job.go
Outdated
| @@ -15,13 +17,14 @@ import ( | |||
|
|
|||
| // NewJobsAPI creates JobsAPI instance from provider meta | |||
| func NewJobsAPI(ctx context.Context, m interface{}) JobsAPI { | |||
| return JobsAPI{m.(*common.DatabricksClient), ctx} | |||
| return JobsAPI{m.(*common.DatabricksClient), ctx, 20 * time.Minute} | |||
There was a problem hiding this comment.
does it make sense to make timeout configurable? I have seen the situations when stopping the stream could take a significant amount of time
There was a problem hiding this comment.
@alexott stopping the stream as in cancelling the job? could you check? there's no way to call dataplane apis, as they require WebUI token instead of PAT or AAD.
we can add the same timeout configuration as for clusters/workspaces.
* Implements feature #389 * Functionality is triggered only if `always_running` attribute is present * Uses RunsList, RunsCancel and RunNow methods from Jobs API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always_runningattribute is present