Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to handle nested group by retaining the same level #39

Closed
pradeepravi87 opened this issue Jun 15, 2023 · 3 comments
Closed

Ability to handle nested group by retaining the same level #39

pradeepravi87 opened this issue Jun 15, 2023 · 3 comments
Labels
bug Something isn't working migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade

Comments

@pradeepravi87
Copy link

pradeepravi87 commented Jun 15, 2023

With XXX we have seen a scenario where the nested group was created as a main group

@HariGS-DB
Copy link
Contributor

@renardeinside do you know if it handles nested workspace groups? in your code

@nfx nfx added this to the 1 month milestone Sep 18, 2023
@nfx nfx added the bug Something isn't working label Sep 18, 2023
@pohlposition pohlposition added the migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade label Sep 28, 2023
@zpappa
Copy link

zpappa commented Sep 29, 2023

We should be handling nested group logic - dictated in #343

A nested group is still a group, so it should show up as a "main" group. Being nested just implies it's being used by another group, not that it is not visible. Groups may have references to each other but they are still stored and reasoned about as all 1st class objects, i.e. they all live at one place without an implicit hierarchy. This is consistent with how the product works as well as how most IDP systems work.

@zpappa
Copy link

zpappa commented Sep 29, 2023

Closing since #343 handles this

@zpappa zpappa closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade
Projects
None yet
Development

No branches or pull requests

5 participants