Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

having species column name in surveys.csv and species.csv file name is confusing #121

Closed
tracykteal opened this issue Feb 10, 2015 · 6 comments

Comments

@tracykteal
Copy link
Contributor

In the data it's confusing to have a 'species' column in the surveys.csv dataset and a species.csv file. It might be good to rename the 'species' column in surveys.csv to something like 'speciesID'

@tracykteal
Copy link
Contributor Author

Alternatively or in addition, we could rename the species.csv file

@fmichonneau
Copy link
Member

I agree it would be good to rename the column speciesID or species_id.

On Tue, Feb 10, 2015 at 1:28 PM, Tracy Teal notifications@github.com
wrote:

Alternatively or in addition, we could rename the species.csv file


Reply to this email directly or view it on GitHub
#121 (comment)
.

@kcranston
Copy link
Member

I agree about the confusion, and I think the most confusing part is that there are two species columns as well as a species table. The fact that the species column joins to a column with a different name is actually a good thing in terms of teaching how JOIN works.

@kcranston
Copy link
Member

So I vote for renaming the species table (and file) rather than the column IDs. Need to check provenance, though - what is that file called on the Ecological Archives site and do we need to make sure we update the readme with the fact that we have changed it?

@ethanwhite
Copy link
Member

I personally lean towards renaming the column to speciesID as @tracykteal and @fmichonneau suggested. It's true that the different column names help demonstrate a point about joins. But, 1) these are novices so I'm not sure we really need to illustrate this point instead of mentioning it, and 2) I can't think of an equivalently reasonable name for the file/table.

@fmichonneau
Copy link
Member

this is now fixed in the newer version of the dataset that @ethanwhite has uploaded on figshare. Both species.csv and surveys.csv have a column species_id.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants