Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use OrdinaryCallingFormat() if we're on 2.7.9 #77

Merged
merged 3 commits into from
Jan 21, 2016
Merged

Only use OrdinaryCallingFormat() if we're on 2.7.9 #77

merged 3 commits into from
Jan 21, 2016

Conversation

schwanksta
Copy link
Contributor

The patch for OrdinaryCallingFormat(), 08a6f01, causes a S3ResponseError: 301 Moved Permanently error on Python versions before 2.7.9. This patch just checks whether we're >= 2.7.9 before we use that trick.

Actually, it seems to affect versions above 2.7.9 too. Not sure where it stops though.
@palewire
Copy link
Owner

Sorry for the complication. This boto bug is the worst.

@schwanksta
Copy link
Contributor Author

sure as heck ain't you fault

@palewire
Copy link
Owner

Alrighty, let's merge this thing. Should I ship a new version to PyPI?

palewire added a commit that referenced this pull request Jan 21, 2016
Only use OrdinaryCallingFormat() if we're on 2.7.9
@palewire palewire merged commit f1ed1b4 into palewire:master Jan 21, 2016
@schwanksta
Copy link
Contributor Author

Sure, why not. Thanks 👍

@palewire
Copy link
Owner

Done.

$ pip install django-bakery --upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants