Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/db type fix #15

Merged
merged 2 commits into from Oct 6, 2016

Conversation

@glow-mdsol
Copy link
Contributor

glow-mdsol commented Oct 6, 2016

@palewire - I'm an idiot, left in a dangling reference to a non-existent datatype. Please review and merge

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage decreased (-0.01%) to 99.145% when pulling c03e7eb on glow-mdsol:feature/db_type_fix into a3e6106 on datadesk:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage decreased (-0.01%) to 99.145% when pulling c03e7eb on glow-mdsol:feature/db_type_fix into a3e6106 on datadesk:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage decreased (-0.01%) to 99.145% when pulling c03e7eb on glow-mdsol:feature/db_type_fix into a3e6106 on datadesk:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage decreased (-0.01%) to 99.145% when pulling c03e7eb on glow-mdsol:feature/db_type_fix into a3e6106 on datadesk:master.

@palewire

This comment has been minimized.

Copy link
Member

palewire commented Oct 6, 2016

Ah. Got it. This is handled by get_internal_type of the parent class, correct?

@palewire palewire merged commit 154a4d3 into datadesk:master Oct 6, 2016
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.01%) to 99.145%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.