Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags Configuration Documenation #111

Closed
eavestn opened this issue May 22, 2018 · 8 comments
Closed

Tags Configuration Documenation #111

eavestn opened this issue May 22, 2018 · 8 comments
Assignees
Milestone

Comments

@eavestn
Copy link

eavestn commented May 22, 2018

Description

I would like to take advantage of the tags listed in the Integrations section of the documentation.

Issue

How to configure the tags is not explicitly addressed in the documentation, e.g. should a configuration object be passed that specifies both service and tags when initializing the span?

tracer
  .trace('web.request', {
    service: 'my_service',
    tags: { 
       // ...
    }
  })
@eavestn
Copy link
Author

eavestn commented May 22, 2018

I could look at the code; however, for more enterprise-y integrations, listing this will help people feel more confident in the library, itself, I believe.

@rochdev
Copy link
Member

rochdev commented May 22, 2018

@eavestn Actually, these are tags that are automatically added by the integration, so there is nothing to do on your part to get them.

It seems the documentation is not clear on what the listed tags are, so I will improve it for the next release.

@rochdev rochdev added this to the 0.3.0 milestone May 22, 2018
@rochdev rochdev self-assigned this May 22, 2018
@eavestn
Copy link
Author

eavestn commented May 22, 2018

@rochdev I would remove or modify this statement, then:

Each integration can be configured individually.

That leads the reader to believe this is something over which we have control (at least due to where it appears in the doc.s).

Thank you for the quick response!

@rochdev
Copy link
Member

rochdev commented May 22, 2018

@eavestn You have control over the configuration options, but not the tags.

Do you think changing the statement to something like this could work?

Each integration has its own options and can be configured individually. There is also a list of tags that get added automatically to the span created by the integration.

@eavestn
Copy link
Author

eavestn commented May 23, 2018

@rochdev I would suggest something similar:

Each integration has its own list of default tags. These tags get automatically added to the span created by the integration. Every integration is enabled by default; however, which integration is enabled can be individually configured.

Some flavor or combination of the two. Let me know if that above makes sense based on our conversation.

@rochdev
Copy link
Member

rochdev commented May 28, 2018

@eavestn I think it makes sense. I would probably just change the last part to make it clearer that there are configuration options as well.

Something like:

however, each integration can also be enabled and configured individually.

@eavestn
Copy link
Author

eavestn commented May 29, 2018

Looks good to me!

@rochdev
Copy link
Member

rochdev commented May 31, 2018

Released in v0.2.1.

@rochdev rochdev closed this as completed May 31, 2018
@rochdev rochdev modified the milestones: 0.3.0, 0.2.1 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants