-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags Configuration Documenation #111
Comments
I could look at the code; however, for more enterprise-y integrations, listing this will help people feel more confident in the library, itself, I believe. |
@eavestn Actually, these are tags that are automatically added by the integration, so there is nothing to do on your part to get them. It seems the documentation is not clear on what the listed tags are, so I will improve it for the next release. |
@rochdev I would remove or modify this statement, then:
That leads the reader to believe this is something over which we have control (at least due to where it appears in the doc.s). Thank you for the quick response! |
@eavestn You have control over the configuration options, but not the tags. Do you think changing the statement to something like this could work?
|
@rochdev I would suggest something similar:
Some flavor or combination of the two. Let me know if that above makes sense based on our conversation. |
@eavestn I think it makes sense. I would probably just change the last part to make it clearer that there are configuration options as well. Something like:
|
Looks good to me! |
Released in |
Description
I would like to take advantage of the
tags
listed in the Integrations section of the documentation.Issue
How to configure the tags is not explicitly addressed in the documentation, e.g. should a configuration object be passed that specifies both
service
andtags
when initializing the span?The text was updated successfully, but these errors were encountered: