Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of span.log #159

Closed
colintoh opened this issue Jun 21, 2018 · 3 comments
Closed

Implementation of span.log #159

colintoh opened this issue Jun 21, 2018 · 3 comments
Labels
community question Further information is requested

Comments

@colintoh
Copy link

Currently DatadogSpan doesn't implement the _log method and I don't find any way to pass in a custom _log method.

  1. May I know what's the current recommended practice if we wants to be able to use span.log?
  2. Are there any future plans to implement the _log method?

Thanks you :)

@rochdev rochdev added question Further information is requested community labels Jun 21, 2018
@rochdev
Copy link
Member

rochdev commented Jun 21, 2018

  1. Right now logs should be handled by the application itself using a custom logger (i.e. bunyan or winston). There is no specific recommendation since right now span.log is not supported.
  2. There are no plans currently to support this, but we're definitely open to it if there is added value.

@colintoh What would be the expected behavior for your use case when using span.log?

@colintoh
Copy link
Author

@rochdev thanks for getting back quickly.

Our use case

  • We want to be able to get the end-to-end debugging experience in Datadog dashboard
  • span.log send logs (with span context) to the datadog dashboard (https://docs.datadoghq.com/logs/)
  • Datadog APM is able to link the span with the related logs. Hence, when we want to dive deeper into the specific trace in APM, we are able to view the related logs for it

@andrewsouthard1
Copy link

Hey @colintoh - we've since added the ability to both automatically/manually inject trace ids into logs - which connect logs/traces in Datadog: https://docs.datadoghq.com/tracing/connect_logs_and_traces/nodejs Let us know if you have any questions or believe we have not covered your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants